Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-1971: Add the include-defaults flag to the endpoint for 'getToolDetails'. #561

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

ianmcorvidae
Copy link
Member

defaults to include-defaults=false since most places that should include them aren't via this endpoint.

I'm not sure if there's more I'll need to do in this service, but it depends on cyverse-de/apps#266 and the corresponding common-swagger-api and terrain PRs anyway.

…efault to include-defaults=false since most places that should include them aren't via this endpoint.
Copy link
Member

@slr71 slr71 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@ianmcorvidae ianmcorvidae merged commit f86eb47 into cyverse-de:master Jan 4, 2024
4 of 6 checks passed
@ianmcorvidae ianmcorvidae deleted the core-1971 branch January 4, 2024 18:19
psarando added a commit that referenced this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants